]> git.street.me.uk Git - andy/viking.git/commitdiff
Fix small memory leak
authorRob Norris <rw_norris@hotmail.com>
Fri, 13 Jan 2017 00:07:55 +0000 (00:07 +0000)
committerRob Norris <rw_norris@hotmail.com>
Sat, 14 Jan 2017 12:23:41 +0000 (12:23 +0000)
src/vikgpslayer.c

index 1736bcfcc029d0f04cae3a97902d9d240fff6c7d..742dcc560c40cfc283c4cf005318ec12c18c5934 100644 (file)
@@ -1696,6 +1696,13 @@ static gboolean gpsd_data_available(GIOChannel *source, GIOCondition condition,
   return FALSE; /* no further calling */
 }
 
+/**
+ * make_track_name:
+ *
+ * returns allocated string for a new realtime track name
+ * NB no i18n ATM
+ * free string after use
+ */
 static gchar *make_track_name(VikTrwLayer *vtl)
 {
   const gchar basename[] = "REALTIME";
@@ -1709,7 +1716,6 @@ static gchar *make_track_name(VikTrwLayer *vtl)
     i++;
   }
   return(name);
-
 }
 
 static gboolean rt_gpsd_try_connect(gpointer *data)
@@ -1749,7 +1755,9 @@ static gboolean rt_gpsd_try_connect(gpointer *data)
     VikTrwLayer *vtl = vgl->trw_children[TRW_REALTIME];
     vgl->realtime_track = vik_track_new();
     vgl->realtime_track->visible = TRUE;
-    vik_trw_layer_add_track(vtl, make_track_name(vtl), vgl->realtime_track);
+    gchar *name = make_track_name(vtl);
+    vik_trw_layer_add_track(vtl, name, vgl->realtime_track);
+    g_free(name);
   }
 
 #if GPSD_API_MAJOR_VERSION == 3 || GPSD_API_MAJOR_VERSION == 4