From: Rob Norris Date: Tue, 10 Sep 2013 22:03:08 +0000 (+0100) Subject: [QA] Fixup if statement intention. X-Git-Url: https://git.street.me.uk/andy/viking.git/commitdiff_plain/fe6ce05435a47d5bd517ed24a2bc5ef5512c3a43 [QA] Fixup if statement intention. Highlighted as issue when compiling with clang 3.2 --- diff --git a/src/vikgpslayer.c b/src/vikgpslayer.c index 4e1f7467..14aa083d 100644 --- a/src/vikgpslayer.c +++ b/src/vikgpslayer.c @@ -562,8 +562,8 @@ static gboolean gps_layer_set_param ( VikGpsLayer *vgl, guint16 id, VikLayerPara break; case PARAM_GPSD_PORT: if (data.s) { - if (vgl->gpsd_port); - g_free(vgl->gpsd_port); + if (vgl->gpsd_port) + g_free(vgl->gpsd_port); vgl->gpsd_port = g_strdup(data.s); } break;