X-Git-Url: https://git.street.me.uk/andy/viking.git/blobdiff_plain/c390aa7107de21b24033999fc9a9ce26c0f8981c..c3cf4e3e0f27e9c6b05cab2fd5700831878f601f:/src/viktreeview.c?ds=inline diff --git a/src/viktreeview.c b/src/viktreeview.c index 50a59de6..a91c4d84 100644 --- a/src/viktreeview.c +++ b/src/viktreeview.c @@ -19,7 +19,13 @@ * */ +#ifdef HAVE_CONFIG_H +#include "config.h" +#endif + #include +#include + #include #include "viking.h" @@ -59,6 +65,8 @@ struct _VikTreeview { GtkTreeModel *model; GdkPixbuf *layer_type_icons[VIK_LAYER_NUM_TYPES]; + + gboolean was_a_toggle; }; /* TODO: find, make "static" and put up here all non-"a_" functions */ @@ -125,13 +133,95 @@ static void treeview_edited_cb (GtkCellRendererText *cell, gchar *path_str, cons static void treeview_toggled_cb (GtkCellRendererToggle *cell, gchar *path_str, VikTreeview *vt) { - GtkTreeIter iter; + GtkTreeIter iter_toggle; + GtkTreeIter iter_selected; /* get type and data */ - vik_treeview_get_iter_from_path_str ( vt, &iter, path_str ); + vik_treeview_get_iter_from_path_str ( vt, &iter_toggle, path_str ); + + GtkTreePath *tp_toggle = gtk_tree_model_get_path ( vt->model, &iter_toggle ); + + if ( gtk_tree_selection_get_selected ( gtk_tree_view_get_selection ( GTK_TREE_VIEW ( vt ) ), NULL, &iter_selected ) ) { + GtkTreePath *tp_selected = gtk_tree_model_get_path ( vt->model, &iter_selected ); + if ( gtk_tree_path_compare ( tp_toggle, tp_selected ) ) + // Toggle set on different path + // therefore prevent subsequent auto selection (otherwise no action needed) + vt->was_a_toggle = TRUE; + } + else + // Toggle set on new path + // therefore prevent subsequent auto selection + vt->was_a_toggle = TRUE; - g_signal_emit ( G_OBJECT(vt), -treeview_signals[VT_ITEM_TOGGLED_SIGNAL], 0, &iter ); + g_signal_emit ( G_OBJECT(vt), treeview_signals[VT_ITEM_TOGGLED_SIGNAL], 0, &iter_toggle ); +} + +/* Inspired by GTK+ test + * http://git.gnome.org/browse/gtk+/tree/tests/testtooltips.c + */ +static gboolean +treeview_tooltip_cb (GtkWidget *widget, + gint x, + gint y, + gboolean keyboard_tip, + GtkTooltip *tooltip, + gpointer data) +{ + GtkTreeIter iter; + GtkTreeView *tree_view = GTK_TREE_VIEW (widget); + GtkTreeModel *model = gtk_tree_view_get_model (tree_view); + GtkTreePath *path = NULL; + + char buffer[256]; + + if (!gtk_tree_view_get_tooltip_context (tree_view, &x, &y, + keyboard_tip, + &model, &path, &iter)) + return FALSE; + + /* ATM normally treeview doesn't call into layers - maybe another level of redirection required? */ + gint rv; + gtk_tree_model_get (model, &iter, TYPE_COLUMN, &rv, -1); + if ( rv == VIK_TREEVIEW_TYPE_SUBLAYER ) { + + gtk_tree_model_get (model, &iter, ITEM_DATA_COLUMN, &rv, -1); + // No tooltips ATM for the immediate Tracks / Waypoints tree list + if ( rv == 0 || rv == 1 ) + // VIK_TRW_LAYER_SUBLAYER_WAYPOINTS or VIK_TRW_LAYER_SUBLAYER_TRACKS + return FALSE; + + gpointer sublayer; + gtk_tree_model_get (model, &iter, ITEM_POINTER_COLUMN, &sublayer, -1); + + gpointer parent; + gtk_tree_model_get (model, &iter, ITEM_PARENT_COLUMN, &parent, -1); + + g_snprintf (buffer, sizeof(buffer), "%s", vik_layer_sublayer_tooltip (VIK_LAYER(parent), rv, sublayer)); + } + else if ( rv == VIK_TREEVIEW_TYPE_LAYER ) { + gpointer layer; + gtk_tree_model_get (model, &iter, ITEM_POINTER_COLUMN, &layer, -1); + g_snprintf (buffer, sizeof(buffer), "%s", vik_layer_layer_tooltip (VIK_LAYER(layer))); + } + else + return FALSE; + + // Don't display null strings :) + if ( strncmp (buffer, "(null)", 6) == 0 ) { + return FALSE; + } + else { + // No point in using (Pango) markup verson - gtk_tooltip_set_markup() + // especially as waypoint comments may well contain HTML markup which confuses the pango markup parser + // This plain text is probably faster too. + gtk_tooltip_set_text (tooltip, buffer); + } + + gtk_tree_view_set_tooltip_row (tree_view, tooltip, path); + + gtk_tree_path_free (path); + + return TRUE; } VikTreeview *vik_treeview_new () @@ -146,6 +236,13 @@ gint vik_treeview_item_get_type ( VikTreeview *vt, GtkTreeIter *iter ) return rv; } +gchar* vik_treeview_item_get_name ( VikTreeview *vt, GtkTreeIter *iter ) +{ + gchar *rv; + TREEVIEW_GET ( vt->model, iter, NAME_COLUMN, &rv ); + return rv; +} + gint vik_treeview_item_get_data ( VikTreeview *vt, GtkTreeIter *iter ) { gint rv; @@ -183,51 +280,50 @@ static void treeview_add_columns ( VikTreeview *vt ) GtkCellRenderer *renderer; GtkTreeViewColumn *column; + /* Layer column */ renderer = gtk_cell_renderer_text_new (); g_signal_connect (renderer, "edited", G_CALLBACK (treeview_edited_cb), vt); - g_object_set (G_OBJECT (renderer), "xalign", 0.0, NULL); + g_object_set (G_OBJECT (renderer), "xalign", 0.0, "ellipsize", PANGO_ELLIPSIZE_END, NULL); col_offset = gtk_tree_view_insert_column_with_attributes (GTK_TREE_VIEW (vt), - -1, "Layer Name", + -1, _("Layer Name"), renderer, "text", NAME_COLUMN, "editable", EDITABLE_COLUMN, NULL); + /* ATM the minimum overall width (and starting default) of the treeview size is determined + by the buttons added to the bottom of the layerspanel */ column = gtk_tree_view_get_column (GTK_TREE_VIEW (vt), col_offset - 1); gtk_tree_view_column_set_sizing (GTK_TREE_VIEW_COLUMN (column), - GTK_TREE_VIEW_COLUMN_FIXED); - gtk_tree_view_column_set_fixed_width (GTK_TREE_VIEW_COLUMN (column), 100); - gtk_tree_view_column_set_clickable (GTK_TREE_VIEW_COLUMN (column), TRUE); - gtk_tree_view_column_set_resizable (GTK_TREE_VIEW_COLUMN (column), TRUE); + GTK_TREE_VIEW_COLUMN_FIXED); + gtk_tree_view_column_set_expand (GTK_TREE_VIEW_COLUMN (column), TRUE); + /* Layer type */ renderer = gtk_cell_renderer_pixbuf_new (); - g_object_set (G_OBJECT (renderer), "xalign", 0.0, NULL); + g_object_set (G_OBJECT (renderer), "xalign", 0.5, NULL); col_offset = gtk_tree_view_insert_column_with_attributes (GTK_TREE_VIEW (vt), - -1, "Type", + -1, "", renderer, "pixbuf", ICON_COLUMN, NULL); - column = gtk_tree_view_get_column (GTK_TREE_VIEW (vt), col_offset - 1); - gtk_tree_view_column_set_fixed_width (GTK_TREE_VIEW_COLUMN (column), 33); gtk_tree_view_column_set_sizing (GTK_TREE_VIEW_COLUMN (column), - GTK_TREE_VIEW_COLUMN_FIXED); - gtk_tree_view_column_set_clickable (GTK_TREE_VIEW_COLUMN (column), TRUE); - + GTK_TREE_VIEW_COLUMN_AUTOSIZE); + /* Layer visible */ renderer = gtk_cell_renderer_toggle_new (); - g_object_set (G_OBJECT (renderer), "xalign", 0.0, NULL); + g_object_set (G_OBJECT (renderer), "xalign", 0.5, NULL); g_signal_connect (renderer, "toggled", G_CALLBACK (treeview_toggled_cb), vt); col_offset = gtk_tree_view_insert_column_with_attributes (GTK_TREE_VIEW (vt), - -1, "Visible", + -1, "", renderer, "active", VISIBLE_COLUMN, @@ -238,20 +334,94 @@ static void treeview_add_columns ( VikTreeview *vt ) NULL); column = gtk_tree_view_get_column (GTK_TREE_VIEW (vt), col_offset - 1); - gtk_tree_view_column_set_fixed_width (GTK_TREE_VIEW_COLUMN (column), 40); gtk_tree_view_column_set_sizing (GTK_TREE_VIEW_COLUMN (column), - GTK_TREE_VIEW_COLUMN_FIXED); - gtk_tree_view_column_set_clickable (GTK_TREE_VIEW_COLUMN (column), TRUE); + GTK_TREE_VIEW_COLUMN_AUTOSIZE); + + + g_object_set (GTK_TREE_VIEW (vt), "has-tooltip", TRUE, NULL); + g_signal_connect (GTK_TREE_VIEW (vt), "query-tooltip", G_CALLBACK (treeview_tooltip_cb), vt); +} + +static void select_cb(GtkTreeSelection *selection, gpointer data) +{ + VikTreeview *vt = data; + gint type; + GtkTreeIter iter, parent; + VikLayer *vl; + VikWindow * vw; + + gpointer tmp_layer; + VikLayer *tmp_vl = NULL; + gint tmp_subtype = 0; + gint tmp_type = VIK_TREEVIEW_TYPE_LAYER; + + if (!gtk_tree_selection_get_selected(selection, NULL, &iter)) return; + type = vik_treeview_item_get_type( vt, &iter); + + /* Find the Sublayer type if possible */ + tmp_layer = vik_treeview_item_get_pointer ( vt, &iter ); + if (tmp_layer) { + if (type == VIK_TREEVIEW_TYPE_SUBLAYER) { + tmp_vl = VIK_LAYER(vik_treeview_item_get_parent(vt, &iter)); + tmp_subtype = vik_treeview_item_get_data(vt, &iter); + tmp_type = VIK_TREEVIEW_TYPE_SUBLAYER; + } + } + else { + tmp_subtype = vik_treeview_item_get_data(vt, &iter); + tmp_type = VIK_TREEVIEW_TYPE_SUBLAYER; + } + + /* Go up the tree to find the Vik Layer */ + while ( type != VIK_TREEVIEW_TYPE_LAYER ) { + if ( ! vik_treeview_item_get_parent_iter ( vt, &iter, &parent ) ) + return; + iter = parent; + type = vik_treeview_item_get_type (vt, &iter ); + } + + vl = VIK_LAYER( vik_treeview_item_get_pointer ( vt, &iter ) ); + + vw = VIK_WINDOW(VIK_GTK_WINDOW_FROM_LAYER(vl)); + vik_window_selected_layer(vw, vl); + + if (tmp_vl == NULL) + tmp_vl = vl; + /* Apply settings now we have the all details */ + if ( vik_layer_selected ( tmp_vl, + tmp_subtype, + tmp_layer, + tmp_type, + vik_window_layers_panel(vw) ) ) { + /* Redraw required */ + vik_layers_panel_emit_update ( vik_window_layers_panel(vw) ); + } } +static gboolean treeview_selection_filter(GtkTreeSelection *selection, GtkTreeModel *model, GtkTreePath *path, gboolean path_currently_selected, gpointer data) +{ + VikTreeview *vt = data; + + if (vt->was_a_toggle) { + vt->was_a_toggle = FALSE; + return FALSE; + } + + return TRUE; +} + void treeview_init ( VikTreeview *vt ) { guint16 i; + vt->was_a_toggle = FALSE; + vt->model = GTK_TREE_MODEL(gtk_tree_store_new ( NUM_COLUMNS, G_TYPE_STRING, G_TYPE_BOOLEAN, GDK_TYPE_PIXBUF, G_TYPE_INT, G_TYPE_POINTER, G_TYPE_POINTER, G_TYPE_INT, G_TYPE_BOOLEAN, G_TYPE_BOOLEAN )); /* create tree view */ + gtk_tree_selection_set_select_function(gtk_tree_view_get_selection (GTK_TREE_VIEW(vt)), treeview_selection_filter, vt, NULL); + gtk_tree_view_set_model ( GTK_TREE_VIEW(vt), vt->model ); treeview_add_columns ( vt ); g_object_unref (vt->model); @@ -279,6 +449,8 @@ void treeview_init ( VikTreeview *vt ) vt->layer_type_icons[i] = vik_layer_load_icon ( i ); /* if icon can't be loaded, it will be null and simply not be shown. */ gtk_tree_view_set_reorderable (GTK_TREE_VIEW(vt), TRUE); + g_signal_connect(gtk_tree_view_get_selection (GTK_TREE_VIEW (vt)), "changed", + G_CALLBACK(select_cb), vt); } @@ -329,9 +501,26 @@ gboolean vik_treeview_get_iter_at_pos ( VikTreeview *vt, GtkTreeIter *iter, gint return TRUE; } -void vik_treeview_select_iter ( VikTreeview *vt, GtkTreeIter *iter ) +/* Option to ensure visible */ +void vik_treeview_select_iter ( VikTreeview *vt, GtkTreeIter *iter, gboolean view_all ) { - gtk_tree_selection_select_iter ( gtk_tree_view_get_selection ( GTK_TREE_VIEW ( vt ) ), iter ); + GtkTreeView *tree_view = GTK_TREE_VIEW ( vt ); + GtkTreePath *path; + + if ( view_all ) { + path = gtk_tree_model_get_path ( gtk_tree_view_get_model (tree_view), iter ); + gtk_tree_view_expand_to_path ( tree_view, path ); + } + + gtk_tree_selection_select_iter ( gtk_tree_view_get_selection ( tree_view ), iter ); + + if ( view_all ) { + gtk_tree_view_scroll_to_cell ( tree_view, + path, + gtk_tree_view_get_expander_column (tree_view), + FALSE, + 0.0, 0.0 ); + } } gboolean vik_treeview_get_selected_iter ( VikTreeview *vt, GtkTreeIter *iter ) @@ -371,6 +560,11 @@ void vik_treeview_item_select ( VikTreeview *vt, GtkTreeIter *iter ) gtk_tree_selection_select_iter ( gtk_tree_view_get_selection ( GTK_TREE_VIEW ( vt ) ), iter ); } +void vik_treeview_item_unselect ( VikTreeview *vt, GtkTreeIter *iter ) +{ + gtk_tree_selection_unselect_iter ( gtk_tree_view_get_selection ( GTK_TREE_VIEW ( vt ) ), iter ); +} + void vik_treeview_add_layer ( VikTreeview *vt, GtkTreeIter *parent_iter, GtkTreeIter *iter, const gchar *name, gpointer parent, gpointer item, gint data, gint icon_type ) { @@ -379,7 +573,7 @@ void vik_treeview_add_layer ( VikTreeview *vt, GtkTreeIter *parent_iter, GtkTree gtk_tree_store_prepend ( GTK_TREE_STORE(vt->model), iter, parent_iter ); gtk_tree_store_set ( GTK_TREE_STORE(vt->model), iter, NAME_COLUMN, name, VISIBLE_COLUMN, TRUE, TYPE_COLUMN, VIK_TREEVIEW_TYPE_LAYER, ITEM_PARENT_COLUMN, parent, ITEM_POINTER_COLUMN, item, - ITEM_DATA_COLUMN, data, HAS_VISIBLE_COLUMN, TRUE, EDITABLE_COLUMN, TRUE, + ITEM_DATA_COLUMN, data, HAS_VISIBLE_COLUMN, TRUE, EDITABLE_COLUMN, parent == NULL ? FALSE : TRUE, ICON_COLUMN, icon_type >= 0 ? vt->layer_type_icons[icon_type] : NULL, -1 ); } @@ -415,7 +609,7 @@ void vik_treeview_add_sublayer ( VikTreeview *vt, GtkTreeIter *parent_iter, GtkT void vik_treeview_sublayer_realphabetize ( VikTreeview *vt, GtkTreeIter *iter, const gchar *newname ) { GtkTreeIter search_iter, parent_iter; - gchar *search_name; + gchar *search_name = NULL; g_assert ( iter != NULL ); gtk_tree_model_iter_parent ( vt->model, &parent_iter, iter ); @@ -427,8 +621,12 @@ void vik_treeview_sublayer_realphabetize ( VikTreeview *vt, GtkTreeIter *iter, c if ( strcmp ( search_name, newname ) > 0 ) /* not >= or would trip on itself */ { gtk_tree_store_move_before ( GTK_TREE_STORE(vt->model), iter, &search_iter ); + g_free (search_name); + search_name = NULL; return; } + g_free (search_name); + search_name = NULL; } while ( gtk_tree_model_iter_next ( vt->model, &search_iter ) ); gtk_tree_store_move_before ( GTK_TREE_STORE(vt->model), iter, NULL ); @@ -439,7 +637,7 @@ void vik_treeview_add_sublayer_alphabetized gint data, GdkPixbuf *icon, gboolean has_visible, gboolean editable ) { GtkTreeIter search_iter; - gchar *search_name; + gchar *search_name = NULL; g_assert ( iter != NULL ); if ( gtk_tree_model_iter_children ( vt->model, &search_iter, parent_iter ) ) @@ -451,8 +649,12 @@ void vik_treeview_add_sublayer_alphabetized { gtk_tree_store_insert_before ( GTK_TREE_STORE(vt->model), iter, parent_iter, &search_iter ); found_greater_string = TRUE; + g_free (search_name); + search_name = NULL; break; } + g_free (search_name); + search_name = NULL; } while ( gtk_tree_model_iter_next ( vt->model, &search_iter ) ); if ( ! found_greater_string ) @@ -481,19 +683,16 @@ static void treeview_finalize ( GObject *gob ) static gboolean treeview_drag_data_received (GtkTreeDragDest *drag_dest, GtkTreePath *dest, GtkSelectionData *selection_data) { GtkTreeModel *tree_model; - GtkTreeStore *tree_store; GtkTreeModel *src_model = NULL; GtkTreePath *src_path = NULL, *dest_cp = NULL; gboolean retval = FALSE; - GtkTreeIter src_iter, root_iter, dest_iter, dest_parent; - guint *i_src = NULL; + GtkTreeIter src_iter, root_iter, dest_parent; VikTreeview *vt; VikLayer *vl; g_return_val_if_fail (GTK_IS_TREE_STORE (drag_dest), FALSE); tree_model = GTK_TREE_MODEL (drag_dest); - tree_store = GTK_TREE_STORE (drag_dest); if (gtk_tree_get_row_drag_data (selection_data, &src_model, &src_path) && src_model == tree_model) { /* @@ -517,7 +716,6 @@ static gboolean treeview_drag_data_received (GtkTreeDragDest *drag_dest, GtkTree goto out; } - i_src = gtk_tree_path_get_indices (src_path); dest_cp = gtk_tree_path_copy (dest); gtk_tree_model_get_iter_first(tree_model, &root_iter); @@ -528,13 +726,9 @@ static gboolean treeview_drag_data_received (GtkTreeDragDest *drag_dest, GtkTree if (gtk_tree_path_get_depth(dest_cp)>1) { /* can't be sibling of top layer */ VikLayer *vl_src, *vl_dest; - /* Find the first ancestor that is a full layer, and store in dest_parent. - * In addition, put in dest_iter where Gtk wants us to insert the dragged object. - * (Note that this may end up being an invalid iter). - */ + /* Find the first ancestor that is a full layer, and store in dest_parent. */ do { gtk_tree_path_up(dest_cp); - dest_iter = dest_parent; gtk_tree_model_get_iter (src_model, &dest_parent, dest_cp); } while (gtk_tree_path_get_depth(dest_cp)>1 && vik_treeview_item_get_type(vt, &dest_parent) != VIK_TREEVIEW_TYPE_LAYER); @@ -567,7 +761,7 @@ static gboolean treeview_drag_data_received (GtkTreeDragDest *drag_dest, GtkTree static gboolean treeview_drag_data_delete ( GtkTreeDragSource *drag_source, GtkTreePath *path ) { gchar *s_dest = gtk_tree_path_to_string(path); - g_print("delete data from %s\n", s_dest); + g_print(_("delete data from %s\n"), s_dest); g_free(s_dest); return FALSE; }