a_gpx_write_file(vt, f);
fclose(f);
f = NULL;
- ret = a_babel_convert_from ( vt, bargs, cb, name_src, user_data );
+ ret = a_babel_convert_from ( vt, bargs, name_src, cb, user_data );
g_remove(name_src);
g_free(name_src);
}
return ret;
}
-#ifdef WINDOWS
-static gboolean babel_general_convert( BabelStatusFunc cb, gchar **args, gpointer user_data )
+/**
+ * Perform any cleanup actions once GPSBabel has completed running
+ */
+static void babel_watch ( GPid pid,
+ gint status,
+ gpointer user_data )
{
- gboolean ret;
- FILE *f;
- gchar *cmd;
- gchar **args2;
-
- STARTUPINFO si;
- PROCESS_INFORMATION pi;
-
- ZeroMemory( &si, sizeof(si) );
- ZeroMemory( &pi, sizeof(pi) );
- si.cb = sizeof(si);
- si.dwFlags = STARTF_USESHOWWINDOW;
- si.wShowWindow = SW_HIDE;
-
- cmd = g_strjoinv( " ", args);
- args2 = g_strsplit(cmd, "\\", 0);
- g_free(cmd);
- cmd = g_strjoinv( "\\\\", args2);
- g_free(args2);
- args2 = g_strsplit(cmd, "/", 0);
- g_free(cmd);
- cmd = g_strjoinv( "\\\\", args2);
-
- if( !CreateProcess(
- NULL, // No module name (use command line).
- (LPTSTR)cmd, // Command line.
- NULL, // Process handle not inheritable.
- NULL, // Thread handle not inheritable.
- FALSE, // Set handle inheritance to FALSE.
- 0, // No creation flags.
- NULL, // Use parent's environment block.
- NULL, // Use parent's starting directory.
- &si, // Pointer to STARTUPINFO structure.
- &pi ) // Pointer to PROCESS_INFORMATION structure.
- ){
- g_error ( "CreateProcess failed" );
- ret = FALSE;
- }
- else {
- WaitForSingleObject(pi.hProcess, INFINITE);
- WaitForSingleObject(pi.hThread, INFINITE);
-
- CloseHandle(pi.hThread);
- CloseHandle(pi.hProcess);
-
- if ( cb )
- cb(BABEL_DONE, NULL, user_data);
-
- ret = TRUE;
- }
-
- g_strfreev( args2 );
- g_free( cmd );
-
- return ret;
+ g_spawn_close_pid ( pid );
}
-/* Windows */
-#else
-/* Posix */
+
+/**
+ * babel_general_convert:
+ * @args: The command line arguments passed to GPSBabel
+ * @cb: callback that is run for each line of GPSBabel output and at completion of the run
+ * callback may be NULL
+ * @user_data: passed along to cb
+ *
+ * The function to actually invoke the GPSBabel external command
+ *
+ * Returns: %TRUE on successful invocation of GPSBabel command
+ */
static gboolean babel_general_convert( BabelStatusFunc cb, gchar **args, gpointer user_data )
{
gboolean ret = FALSE;
GError *error = NULL;
gint babel_stdout;
- if (!g_spawn_async_with_pipes (NULL, args, NULL, 0, NULL, NULL, &pid, NULL, &babel_stdout, NULL, &error)) {
+ if (!g_spawn_async_with_pipes (NULL, args, NULL, G_SPAWN_DO_NOT_REAP_CHILD, NULL, NULL, &pid, NULL, &babel_stdout, NULL, &error)) {
g_error("Async command failed: %s", error->message);
g_error_free(error);
ret = FALSE;
cb(BABEL_DONE, NULL, user_data);
fclose(diag);
diag = NULL;
- waitpid(pid, NULL, 0);
- g_spawn_close_pid(pid);
+
+ g_child_watch_add ( pid, (GChildWatchFunc) babel_watch, NULL );
ret = TRUE;
}
return ret;
}
-#endif /* Posix */
/**
* babel_general_convert_from:
+ * @vtl: The TrackWaypoint Layer to save the data into
+ * If it is null it signifies that no data is to be processed,
+ * however the gpsbabel command is still ran as it can be for non-data related options eg:
+ * for use with the power off command - 'command_off'
* @cb: callback that is run upon new data from STDOUT (?)
* (TODO: STDERR would be nice since we usually redirect STDOUT)
* @user_data: passed along to cb
gboolean ret = FALSE;
FILE *f = NULL;
- /* No data required */
- if ( vt == NULL )
- return TRUE;
-
if (babel_general_convert(cb, args, user_data)) {
+ /* No data actually required but still need to have run gpsbabel anyway
+ - eg using the device power command_off */
+ if ( vt == NULL )
+ return TRUE;
+
f = g_fopen(name_dst, "r");
if (f) {
- a_gpx_read_file ( vt, f );
+ ret = a_gpx_read_file ( vt, f );
fclose(f);
f = NULL;
- ret = TRUE;
}
}
*
* Returns: %TRUE on success
*/
-gboolean a_babel_convert_from( VikTrwLayer *vt, const char *babelargs, BabelStatusFunc cb, const char *from, gpointer user_data )
+gboolean a_babel_convert_from( VikTrwLayer *vt, const char *babelargs, const char *from, BabelStatusFunc cb, gpointer user_data )
{
int i,j;
int fd_dst;
g_strfreev(sub_args);
} else
- g_error("gpsbabel not found in PATH");
+ g_critical("gpsbabel not found in PATH");
g_remove(name_dst);
g_free(name_dst);
}
fetch_ret = a_http_download_get_url(url, "", name_src, &options, NULL);
if (fetch_ret == 0)
- ret = a_babel_convert_from( vt, babelargs, NULL, name_src, NULL);
+ ret = a_babel_convert_from( vt, babelargs, name_src, NULL, NULL);
g_remove(name_src);
g_free(babelargs);
static gboolean babel_general_convert_to( VikTrwLayer *vt, BabelStatusFunc cb, gchar **args, const gchar *name_src, gpointer user_data )
{
if (!a_file_export(vt, name_src, FILE_TYPE_GPX, NULL)) {
- g_error("Error exporting to %s", name_src);
+ g_critical("Error exporting to %s", name_src);
return FALSE;
}
return babel_general_convert (cb, args, user_data);
}
-gboolean a_babel_convert_to( VikTrwLayer *vt, const char *babelargs, BabelStatusFunc cb, const char *to, gpointer user_data )
+gboolean a_babel_convert_to( VikTrwLayer *vt, const char *babelargs, const char *to, BabelStatusFunc cb, gpointer user_data )
{
int i,j;
int fd_src;
g_strfreev(sub_args);
} else
- g_error("gpsbabel not found in PATH");
+ g_critical("gpsbabel not found in PATH");
g_remove(name_src);
g_free(name_src);
}
ret = babel_general_convert (load_feature_cb, args, NULL);
} else
- g_error("gpsbabel not found in PATH");
+ g_critical("gpsbabel not found in PATH");
return ret;
}
/* TODO allow to set gpsbabel path via command line */
gpsbabel_loc = g_find_program_in_path( "gpsbabel" );
if ( !gpsbabel_loc )
- g_error( "gpsbabel not found in PATH" );
+ g_critical( "gpsbabel not found in PATH" );
unbuffer_loc = g_find_program_in_path( "unbuffer" );
if ( !unbuffer_loc )
g_warning( "unbuffer not found in PATH" );
{
g_free ( gpsbabel_loc );
g_free ( unbuffer_loc );
+
+ if ( a_babel_file_list ) {
+ GList *gl;
+ for (gl = a_babel_file_list; gl != NULL; gl = g_list_next(gl)) {
+ BabelFile *file = gl->data;
+ g_free ( file->name );
+ g_free ( file->ext );
+ g_free ( file->label );
+ g_free ( gl->data );
+ }
+ g_list_free ( a_babel_file_list );
+ }
+
+ if ( a_babel_device_list ) {
+ GList *gl;
+ for (gl = a_babel_device_list; gl != NULL; gl = g_list_next(gl)) {
+ BabelDevice *device = gl->data;
+ g_free ( device->name );
+ g_free ( device->label );
+ g_free ( gl->data );
+ }
+ g_list_free ( a_babel_device_list );
+ }
+
}
projects / andy / viking.git / blobdiff