]> git.street.me.uk Git - andy/viking.git/blobdiff - src/vikgpslayer.c
Remove definition of a non existant function
[andy/viking.git] / src / vikgpslayer.c
index b534d72f6e5c08778e351f062d8a4416dfcc0f8d..276194af87de6438da6a4ad3e89b0a0efbee03a7 100644 (file)
@@ -3,6 +3,7 @@
  *
  * Copyright (C) 2003-2005, Evan Battaglia <gtoevan@gmx.net>
  * Copyright (C) 2006-2008, Quy Tonthat <qtonthat@gmail.com>
+ * Copyright (C) 2016, Rob Norris <rw_norris@hotmail.com>
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -31,6 +32,7 @@
 #include "viking.h"
 #include "icons/icons.h"
 #include "babel.h"
+#include "viktrwlayer.h"
 
 #ifdef HAVE_UNISTD_H
 #include <unistd.h>
 #include <glib/gi18n.h>
 #ifdef VIK_CONFIG_REALTIME_GPS_TRACKING
 #include <gps.h>
-#include "vikutils.h"
 #endif
 
 static VikGpsLayer *vik_gps_layer_create (VikViewport *vp);
-static void vik_gps_layer_realize ( VikGpsLayer *val, VikTreeview *vt, GtkTreeIter *layer_iter );
-static void vik_gps_layer_free ( VikGpsLayer *val );
-static void vik_gps_layer_draw ( VikGpsLayer *val, VikViewport *vp );
+static void vik_gps_layer_realize ( VikGpsLayer *vgl, VikTreeview *vt, GtkTreeIter *layer_iter );
+static void vik_gps_layer_free ( VikGpsLayer *vgl );
+static void vik_gps_layer_draw ( VikGpsLayer *vgl, VikViewport *vp );
 static VikGpsLayer *vik_gps_layer_new ( VikViewport *vp );
+static void vik_gps_layer_post_read ( VikGpsLayer *vgl, VikViewport *vp, gboolean from_file );
 
-static void gps_layer_marshall( VikGpsLayer *val, guint8 **data, gint *len );
+static void gps_layer_marshall( VikGpsLayer *vgl, guint8 **data, gint *len );
 static VikGpsLayer *gps_layer_unmarshall( guint8 *data, gint len, VikViewport *vvp );
-static gboolean gps_layer_set_param ( VikGpsLayer *vgl, guint16 id, VikLayerParamData data, VikViewport *vp, gboolean is_file_operation );
+static gboolean gps_layer_set_param ( VikGpsLayer *vgl, VikLayerSetParam *vlsp );
 static VikLayerParamData gps_layer_get_param ( VikGpsLayer *vgl, guint16 id, gboolean is_file_operation );
 
 static const gchar* gps_layer_tooltip ( VikGpsLayer *vgl );
 
-static void gps_layer_change_coord_mode ( VikGpsLayer *val, VikCoordMode mode );
+static void gps_layer_change_coord_mode ( VikGpsLayer *vgl, VikCoordMode mode );
 static void gps_layer_add_menu_items( VikGpsLayer *vtl, GtkMenu *menu, gpointer vlp );
 
 static void gps_upload_cb( gpointer layer_and_vlp[2] );
@@ -96,25 +98,34 @@ static gchar * old_params_ports[] = {"/dev/ttyS0", "/dev/ttyS1", "/dev/ttyUSB0",
 
 typedef struct {
   GMutex *mutex;
+  gboolean ok;
+  gboolean thread_complete;
   vik_gps_dir direction;
   gchar *port;
-  gboolean ok;
-  gint total_count;
-  gint count;
+  gint wpt_total_count;
+  gint wpt_count;
+  gint trk_total_count;
+  gint trk_count;
+  gint rte_total_count;
+  gint rte_count;
   VikTrwLayer *vtl;
   VikTrack *track;
   gchar *babelargs;
-  gchar *window_title;
   GtkWidget *dialog;
   GtkWidget *status_label;
   GtkWidget *gps_label;
-  GtkWidget *ver_label;
-  GtkWidget *id_label;
-  GtkWidget *wp_label;
+  GtkWidget *wpt_label;
   GtkWidget *trk_label;
   GtkWidget *rte_label;
-  GtkWidget *progress_label;
   vik_gps_xfer_type progress_type;
+  gboolean result;
+  gchar *info;
+  // GUI Updates
+  gint id_status_working;
+  gint id_status_end;
+  gint id_info;
+  gint id_total_count;
+  gint id_count;
   VikViewport *vvp;
 #if defined (VIK_CONFIG_REALTIME_GPS_TRACKING) && defined (GPSD_API_MAJOR_VERSION)
   gboolean realtime_tracking;
@@ -215,6 +226,7 @@ static VikLayerParam gps_layer_params[] = {
   { VIK_LAYER_GPS, "center_start_tracking", VIK_LAYER_PARAM_BOOLEAN, GROUP_REALTIME_MODE, N_("Jump to current position on start"), VIK_LAYER_WIDGET_CHECKBUTTON, NULL, NULL, NULL, vik_lpd_false_default, NULL, NULL },
   { VIK_LAYER_GPS, "moving_map_method", VIK_LAYER_PARAM_UINT, GROUP_REALTIME_MODE, N_("Moving Map Method:"), VIK_LAYER_WIDGET_RADIOGROUP_STATIC, params_vehicle_position, NULL, NULL, moving_map_method_default, NULL, NULL },
   { VIK_LAYER_GPS, "realtime_update_statusbar", VIK_LAYER_PARAM_BOOLEAN, GROUP_REALTIME_MODE, N_("Update Statusbar:"), VIK_LAYER_WIDGET_CHECKBUTTON, NULL, NULL, N_("Display information in the statusbar on GPS updates"), vik_lpd_true_default, NULL, NULL },
+  { VIK_LAYER_GPS, "auto_connect", VIK_LAYER_PARAM_BOOLEAN, GROUP_REALTIME_MODE, N_("Auto Connect"), VIK_LAYER_WIDGET_CHECKBUTTON, NULL, NULL, N_("Automatically connect to GPSD"), vik_lpd_false_default, NULL, NULL },
   { VIK_LAYER_GPS, "gpsd_host", VIK_LAYER_PARAM_STRING, GROUP_REALTIME_MODE, N_("Gpsd Host:"), VIK_LAYER_WIDGET_ENTRY, NULL, NULL, NULL, gpsd_host_default, NULL, NULL },
   { VIK_LAYER_GPS, "gpsd_port", VIK_LAYER_PARAM_STRING, GROUP_REALTIME_MODE, N_("Gpsd Port:"), VIK_LAYER_WIDGET_ENTRY, NULL, NULL, NULL, gpsd_port_default, NULL, NULL },
   { VIK_LAYER_GPS, "gpsd_retry_interval", VIK_LAYER_PARAM_STRING, GROUP_REALTIME_MODE, N_("Gpsd Retry Interval (seconds):"), VIK_LAYER_WIDGET_ENTRY, NULL, NULL, NULL, gpsd_retry_interval_default, NULL, NULL },
@@ -230,6 +242,7 @@ enum {
   PARAM_REALTIME_CENTER_START,
   PARAM_VEHICLE_POSITION,
   PARAM_REALTIME_UPDATE_STATUSBAR,
+  PARAM_GPSD_CONNECT,
   PARAM_GPSD_HOST,
   PARAM_GPSD_PORT,
   PARAM_GPSD_RETRY_INTERVAL,
@@ -254,7 +267,7 @@ VikLayerInterface vik_gps_layer_interface = {
 
   (VikLayerFuncCreate)                  vik_gps_layer_create,
   (VikLayerFuncRealize)                 vik_gps_layer_realize,
-  (VikLayerFuncPostRead)                NULL,
+  (VikLayerFuncPostRead)                vik_gps_layer_post_read,
   (VikLayerFuncFree)                    vik_gps_layer_free,
 
   (VikLayerFuncProperties)              NULL,
@@ -314,6 +327,7 @@ static gchar * trw_names[] = {
 typedef struct {
   struct gps_data_t gpsd;
   VikGpsLayer *vgl;
+  int gpsd_open;
 } VglGpsd;
 
 typedef struct {
@@ -330,7 +344,8 @@ struct _VikGpsLayer {
   int cur_read_child;   /* used only for reading file */
 #if defined (VIK_CONFIG_REALTIME_GPS_TRACKING) && defined (GPSD_API_MAJOR_VERSION)
   VglGpsd *vgpsd;
-  gboolean realtime_tracking;  /* set/reset only by the callback */
+  gboolean connected_to_gpsd;
+  gboolean realtime_tracking;
   gboolean first_realtime_trackpoint;
   GpsFix realtime_fix;
   GpsFix last_fix;
@@ -347,6 +362,7 @@ struct _VikGpsLayer {
   GdkGC *realtime_track_pt2_gc;
 
   /* params */
+  gboolean auto_connect_to_gpsd;
   gchar *gpsd_host;
   gchar *gpsd_port;
   gint gpsd_retry_interval;
@@ -428,7 +444,26 @@ static VikGpsLayer *vik_gps_layer_create (VikViewport *vp)
 
 static const gchar* gps_layer_tooltip ( VikGpsLayer *vgl )
 {
-  return vgl->protocol;
+  static gchar buf1[256];
+  buf1[0] = '\0';
+  static gchar rbuf[512];
+  rbuf[0] = '\0';
+
+  g_snprintf (buf1, sizeof(buf1), "%s:%s", vgl->protocol, vgl->serial_port);
+
+#if defined (VIK_CONFIG_REALTIME_GPS_TRACKING) && defined (GPSD_API_MAJOR_VERSION)
+  static gchar buf2[256];
+  buf2[0] = '\0';
+  if ( vgl->connected_to_gpsd )
+    g_snprintf (buf2, sizeof(buf2), "GPSD:%s:%s %s", vgl->gpsd_host, vgl->gpsd_port, _("Connected"));
+  else
+    g_snprintf (buf2, sizeof(buf2), "GPSD:%s:%s %s", vgl->gpsd_host, vgl->gpsd_port, _("Disconnected"));
+
+  g_snprintf (rbuf, sizeof(rbuf), "%s\n%s", buf1, buf2);
+#else
+  g_snprintf (rbuf, sizeof(rbuf), "%s", buf1);
+#endif
+  return rbuf;
 }
 
 /* "Copy" */
@@ -496,93 +531,96 @@ static VikGpsLayer *gps_layer_unmarshall( guint8 *data, gint len, VikViewport *v
 #undef alm_next
 }
 
-static gboolean gps_layer_set_param ( VikGpsLayer *vgl, guint16 id, VikLayerParamData data, VikViewport *vp, gboolean is_file_operation )
+static gboolean gps_layer_set_param ( VikGpsLayer *vgl, VikLayerSetParam *vlsp )
 {
-  switch ( id )
+  switch ( vlsp->id )
   {
     case PARAM_PROTOCOL:
-      if (data.s) {
+      if (vlsp->data.s) {
         g_free(vgl->protocol);
         // Backwards Compatibility: previous versions <v1.4 stored protocol as an array index
-        int index = data.s[0] - '0';
-        if (data.s[0] != '\0' &&
-            g_ascii_isdigit (data.s[0]) &&
-            data.s[1] == '\0' &&
+        int index = vlsp->data.s[0] - '0';
+        if (vlsp->data.s[0] != '\0' &&
+            g_ascii_isdigit (vlsp->data.s[0]) &&
+            vlsp->data.s[1] == '\0' &&
             index < OLD_NUM_PROTOCOLS)
           // It is a single digit: activate compatibility
           vgl->protocol = g_strdup(protocols_args[index]);
         else
-          vgl->protocol = g_strdup(data.s);
+          vgl->protocol = g_strdup(vlsp->data.s);
         g_debug("%s: %s", __FUNCTION__, vgl->protocol);
       }
       else
         g_warning(_("Unknown GPS Protocol"));
       break;
     case PARAM_PORT:
-      if (data.s) {
+      if (vlsp->data.s) {
         g_free(vgl->serial_port);
         // Backwards Compatibility: previous versions <v0.9.91 stored serial_port as an array index
-        int index = data.s[0] - '0';
-        if (data.s[0] != '\0' &&
-            g_ascii_isdigit (data.s[0]) &&
-            data.s[1] == '\0' &&
+        int index = vlsp->data.s[0] - '0';
+        if (vlsp->data.s[0] != '\0' &&
+            g_ascii_isdigit (vlsp->data.s[0]) &&
+            vlsp->data.s[1] == '\0' &&
             index < OLD_NUM_PORTS)
           /* It is a single digit: activate compatibility */
           vgl->serial_port = g_strdup(old_params_ports[index]);
         else
-          vgl->serial_port = g_strdup(data.s);
+          vgl->serial_port = g_strdup(vlsp->data.s);
         g_debug("%s: %s", __FUNCTION__, vgl->serial_port);
       }
       else
         g_warning(_("Unknown serial port device"));
       break;
     case PARAM_DOWNLOAD_TRACKS:
-      vgl->download_tracks = data.b;
+      vgl->download_tracks = vlsp->data.b;
       break;
     case PARAM_UPLOAD_TRACKS:
-      vgl->upload_tracks = data.b;
+      vgl->upload_tracks = vlsp->data.b;
       break;
     case PARAM_DOWNLOAD_ROUTES:
-      vgl->download_routes = data.b;
+      vgl->download_routes = vlsp->data.b;
       break;
     case PARAM_UPLOAD_ROUTES:
-      vgl->upload_routes = data.b;
+      vgl->upload_routes = vlsp->data.b;
       break;
     case PARAM_DOWNLOAD_WAYPOINTS:
-      vgl->download_waypoints = data.b;
+      vgl->download_waypoints = vlsp->data.b;
       break;
     case PARAM_UPLOAD_WAYPOINTS:
-      vgl->upload_waypoints = data.b;
+      vgl->upload_waypoints = vlsp->data.b;
       break;
 #if defined (VIK_CONFIG_REALTIME_GPS_TRACKING) && defined (GPSD_API_MAJOR_VERSION)
+    case PARAM_GPSD_CONNECT:
+      vgl->auto_connect_to_gpsd = vlsp->data.b;
+      break;
     case PARAM_GPSD_HOST:
-      if (data.s) {
+      if (vlsp->data.s) {
         if (vgl->gpsd_host)
           g_free(vgl->gpsd_host);
-        vgl->gpsd_host = g_strdup(data.s);
+        vgl->gpsd_host = g_strdup(vlsp->data.s);
       }
       break;
     case PARAM_GPSD_PORT:
-      if (data.s) {
+      if (vlsp->data.s) {
         if (vgl->gpsd_port)
           g_free(vgl->gpsd_port);
-        vgl->gpsd_port = g_strdup(data.s);
+        vgl->gpsd_port = g_strdup(vlsp->data.s);
       }
       break;
     case PARAM_GPSD_RETRY_INTERVAL:
-      vgl->gpsd_retry_interval = strtol(data.s, NULL, 10);
+      vgl->gpsd_retry_interval = strtol(vlsp->data.s, NULL, 10);
       break;
     case PARAM_REALTIME_REC:
-      vgl->realtime_record = data.b;
+      vgl->realtime_record = vlsp->data.b;
       break;
     case PARAM_REALTIME_CENTER_START:
-      vgl->realtime_jump_to_start = data.b;
+      vgl->realtime_jump_to_start = vlsp->data.b;
       break;
     case PARAM_VEHICLE_POSITION:
-      vgl->vehicle_position = data.u;
+      vgl->vehicle_position = vlsp->data.u;
       break;
     case PARAM_REALTIME_UPDATE_STATUSBAR:
-      vgl->realtime_update_statusbar = data.b;
+      vgl->realtime_update_statusbar = vlsp->data.b;
       break;
 #endif /* VIK_CONFIG_REALTIME_GPS_TRACKING */
     default:
@@ -624,6 +662,9 @@ static VikLayerParamData gps_layer_get_param ( VikGpsLayer *vgl, guint16 id, gbo
       rv.b = vgl->upload_waypoints;
       break;
 #if defined (VIK_CONFIG_REALTIME_GPS_TRACKING) && defined (GPSD_API_MAJOR_VERSION)
+    case PARAM_GPSD_CONNECT:
+      rv.b = vgl->auto_connect_to_gpsd;
+      break;
     case PARAM_GPSD_HOST:
       rv.s = vgl->gpsd_host ? vgl->gpsd_host : "";
       break;
@@ -687,6 +728,14 @@ VikGpsLayer *vik_gps_layer_new (VikViewport *vp)
   return vgl;
 }
 
+static void vik_gps_layer_post_read ( VikGpsLayer *vgl, VikViewport *vvp, gboolean from_file )
+{
+  for (guint i = 0; i < NUM_TRW; i++) {
+    trw_layer_calculate_bounds_waypoints ( vgl->trw_children[i] );
+    trw_layer_calculate_bounds_tracks ( vgl->trw_children[i] );
+  }
+}
+
 static void vik_gps_layer_draw ( VikGpsLayer *vgl, VikViewport *vp )
 {
   gint i;
@@ -845,6 +894,14 @@ static void vik_gps_layer_realize ( VikGpsLayer *vgl, VikTreeview *vt, GtkTreeIt
     vik_layer_realize ( trw, VIK_LAYER(vgl)->vt, &iter );
     g_signal_connect_swapped ( G_OBJECT(trw), "update", G_CALLBACK(vik_layer_emit_update_secondary), vgl );
   }
+
+#if defined (VIK_CONFIG_REALTIME_GPS_TRACKING) && defined (GPSD_API_MAJOR_VERSION)
+  if ( vgl->auto_connect_to_gpsd ) {
+    vgl->realtime_tracking = TRUE;
+    vgl->first_realtime_trackpoint = TRUE;
+    (void)rt_gpsd_connect ( vgl, FALSE );
+  }
+#endif /* VIK_CONFIG_REALTIME_GPS_TRACKING */
 }
 
 const GList *vik_gps_layer_get_children ( VikGpsLayer *vgl )
@@ -878,110 +935,208 @@ gboolean vik_gps_layer_is_empty ( VikGpsLayer *vgl )
 static void gps_session_delete(GpsSession *sess)
 {
   vik_mutex_free(sess->mutex);
+  // Remove any outstanding GUI update requests
+  if ( sess->id_status_working )
+    g_source_remove ( sess->id_status_working );
+  if ( sess->id_status_end )
+    g_source_remove ( sess->id_status_end );
+  if ( sess->id_info )
+    g_source_remove ( sess->id_info );
+  if ( sess->id_total_count )
+    g_source_remove ( sess->id_total_count );
+  if ( sess->id_count )
+    g_source_remove ( sess->id_count );
   g_free(sess->babelargs);
+  g_free(sess->info);
+  g_free(sess->port);
   g_free(sess);
 }
 
-static void set_total_count(gint cnt, GpsSession *sess)
+static gboolean show_total_count(GpsSession *sess)
 {
-  gchar s[128];
-  gdk_threads_enter();
   g_mutex_lock(sess->mutex);
   if (sess->ok) {
     const gchar *tmp_str;
+    gint tc;
+    GtkWidget *progress_label;
     if (sess->direction == GPS_DOWN)
     {
       switch (sess->progress_type) {
-      case WPT: tmp_str = ngettext("Downloading %d waypoint...", "Downloading %d waypoints...", cnt); sess->total_count = cnt; break;
-      case TRK: tmp_str = ngettext("Downloading %d trackpoint...", "Downloading %d trackpoints...", cnt); sess->total_count = cnt; break;
+      case WPT:
+        tmp_str = ngettext("Downloading %d waypoint...", "Downloading %d waypoints...", sess->wpt_total_count);
+        tc = sess->wpt_total_count;
+        progress_label = sess->wpt_label;
+        break;
+      case TRK:
+        tmp_str = ngettext("Downloading %d trackpoint...", "Downloading %d trackpoints...", sess->trk_total_count);
+        tc = sess->trk_total_count;
+        progress_label = sess->trk_label;
+        break;
       default:
+        tmp_str = ngettext("Downloading %d routepoint...", "Downloading %d routepoints...", sess->rte_total_count);
+        tc = sess->rte_total_count;
+        progress_label = sess->rte_label;
+        break;
+/*
         {
           // Maybe a gpsbabel bug/feature (upto at least v1.4.3 or maybe my Garmin device) but the count always seems x2 too many for routepoints
           gint mycnt = (cnt / 2) + 1;
           tmp_str = ngettext("Downloading %d routepoint...", "Downloading %d routepoints...", mycnt);
-          sess->total_count = mycnt;
+          tc = mycnt;
           break;
         }
+        */
       }
     }
     else
     {
       switch (sess->progress_type) {
-      case WPT: tmp_str = ngettext("Uploading %d waypoint...", "Uploading %d waypoints...", cnt); break;
-      case TRK: tmp_str = ngettext("Uploading %d trackpoint...", "Uploading %d trackpoints...", cnt); break;
-      default: tmp_str = ngettext("Uploading %d routepoint...", "Uploading %d routepoints...", cnt); break;
+      case WPT:
+        tmp_str = ngettext("Uploading %d waypoint...", "Uploading %d waypoints...", sess->wpt_total_count);
+        tc = sess->wpt_total_count;
+        progress_label = sess->wpt_label;
+        break;
+      case TRK:
+        tmp_str = ngettext("Uploading %d trackpoint...", "Uploading %d trackpoints...", sess->trk_total_count);
+        tc = sess->trk_total_count;
+        progress_label = sess->trk_label;
+        break;
+      default:
+        tmp_str = ngettext("Uploading %d routepoint...", "Uploading %d routepoints...", sess->rte_total_count);
+        tc = sess->rte_total_count;
+        progress_label = sess->rte_label;
+        break;
       }
     }
 
-    g_snprintf(s, 128, tmp_str, cnt);
-    gtk_label_set_text ( GTK_LABEL(sess->progress_label), s );
-    gtk_widget_show ( sess->progress_label );
-    sess->total_count = cnt;
+    gchar s[128];
+    g_snprintf(s, 128, tmp_str, tc);
+    gtk_label_set_text ( GTK_LABEL(progress_label), s );
+    gtk_widget_show ( progress_label );
   }
+  sess->id_total_count = 0;
   g_mutex_unlock(sess->mutex);
-  gdk_threads_leave();
+  return FALSE;
 }
 
-static void set_current_count(gint cnt, GpsSession *sess)
+static gboolean show_current_count(GpsSession *sess)
 {
-  gchar s[128];
-  const gchar *tmp_str;
-
-  gdk_threads_enter();
   g_mutex_lock(sess->mutex);
   if (sess->ok) {
-    if (cnt < sess->total_count) {
-      if (sess->direction == GPS_DOWN)
-      {
+    gchar s[128];
+    gint count, total_count;
+    const gchar *tmp_str;
+    GtkWidget *progress_label;
+    if (sess->wpt_count < sess->wpt_total_count) {
+      if (sess->direction == GPS_DOWN) {
         switch (sess->progress_type) {
-        case WPT: tmp_str = ngettext("Downloaded %d out of %d waypoint...", "Downloaded %d out of %d waypoints...", sess->total_count); break;
-        case TRK: tmp_str = ngettext("Downloaded %d out of %d trackpoint...", "Downloaded %d out of %d trackpoints...", sess->total_count); break;
-        default: tmp_str = ngettext("Downloaded %d out of %d routepoint...", "Downloaded %d out of %d routepoints...", sess->total_count); break;
+        case WPT:
+         tmp_str = ngettext("Downloaded %d out of %d waypoint...", "Downloaded %d out of %d waypoints...", sess->wpt_total_count);
+         count = sess->wpt_count;
+         total_count = sess->wpt_total_count;
+         progress_label = sess->wpt_label;
+         break;
+        case TRK:
+         tmp_str = ngettext("Downloaded %d out of %d trackpoint...", "Downloaded %d out of %d trackpoints...", sess->trk_total_count);
+         count = sess->trk_count;
+         total_count = sess->trk_total_count;
+         progress_label = sess->trk_label;
+         break;
+        default:
+         tmp_str = ngettext("Downloaded %d out of %d routepoint...", "Downloaded %d out of %d routepoints...", sess->rte_total_count);
+         count = sess->rte_count;
+         total_count = sess->rte_total_count;
+         progress_label = sess->rte_label;
+         break;
         }
       }
       else {
         switch (sess->progress_type) {
-        case WPT: tmp_str = ngettext("Uploaded %d out of %d waypoint...", "Uploaded %d out of %d waypoints...", sess->total_count); break;
-        case TRK: tmp_str = ngettext("Uploaded %d out of %d trackpoint...", "Uploaded %d out of %d trackpoints...", sess->total_count); break;
-        default: tmp_str = ngettext("Uploaded %d out of %d routepoint...", "Uploaded %d out of %d routepoints...", sess->total_count); break;
-       }
+        case WPT:
+         tmp_str = ngettext("Uploaded %d out of %d waypoint...", "Uploaded %d out of %d waypoints...", sess->wpt_total_count);
+         count = sess->wpt_count;
+         total_count = sess->wpt_total_count;
+         progress_label = sess->wpt_label;
+         break;
+        case TRK:
+         tmp_str = ngettext("Uploaded %d out of %d trackpoint...", "Uploaded %d out of %d trackpoints...", sess->trk_total_count);
+         count = sess->trk_count;
+         total_count = sess->trk_total_count;
+         progress_label = sess->trk_label;
+         break;
+        default:
+         tmp_str = ngettext("Uploaded %d out of %d routepoint...", "Uploaded %d out of %d routepoints...", sess->rte_total_count);
+         count = sess->rte_count;
+         total_count = sess->rte_total_count;
+         progress_label = sess->rte_label;
+         break;
+        }
       }
-      g_snprintf(s, 128, tmp_str, cnt, sess->total_count);
     } else {
-      if (sess->direction == GPS_DOWN)
-      {
+      if (sess->direction == GPS_DOWN) {
         switch (sess->progress_type) {
-        case WPT: tmp_str = ngettext("Downloaded %d waypoint", "Downloaded %d waypoints", cnt); break;
-        case TRK: tmp_str = ngettext("Downloaded %d trackpoint", "Downloaded %d trackpoints", cnt); break;
-        default: tmp_str = ngettext("Downloaded %d routepoint", "Downloaded %d routepoints", cnt); break;
-       }
+        case WPT:
+         tmp_str = ngettext("Downloaded %d waypoint", "Downloaded %d waypoints", sess->wpt_count);
+         count = sess->wpt_count;
+         total_count = sess->wpt_total_count;
+         progress_label = sess->wpt_label;
+         break;
+        case TRK:
+         tmp_str = ngettext("Downloaded %d trackpoint", "Downloaded %d trackpoints", sess->trk_count);
+         count = sess->trk_count;
+         total_count = sess->trk_total_count;
+         progress_label = sess->trk_label;
+         break;
+        default:
+         tmp_str = ngettext("Downloaded %d routepoint", "Downloaded %d routepoints", sess->rte_count);
+         count = sess->rte_count;
+         total_count = sess->rte_total_count;
+         progress_label = sess->rte_label;
+         break;
+        }
       }
       else {
         switch (sess->progress_type) {
-        case WPT: tmp_str = ngettext("Uploaded %d waypoint", "Uploaded %d waypoints", cnt); break;
-        case TRK: tmp_str = ngettext("Uploaded %d trackpoint", "Uploaded %d trackpoints", cnt); break;
-        default: tmp_str = ngettext("Uploaded %d routepoint", "Uploaded %d routepoints", cnt); break;
-       }
+        case WPT:
+         tmp_str = ngettext("Uploaded %d waypoint", "Uploaded %d waypoints", sess->wpt_count);
+         count = sess->wpt_count;
+         total_count = sess->wpt_total_count;
+         progress_label = sess->wpt_label;
+         break;
+        case TRK:
+         tmp_str = ngettext("Uploaded %d trackpoint", "Uploaded %d trackpoints", sess->trk_count);
+         count = sess->trk_count;
+         total_count = sess->trk_total_count;
+         progress_label = sess->trk_label;
+         break;
+        default:
+         tmp_str = ngettext("Uploaded %d routepoint", "Uploaded %d routepoints", sess->rte_count);
+         count = sess->rte_count;
+         total_count = sess->rte_total_count;
+         progress_label = sess->rte_label;
+         break;
+        }
       }
-      g_snprintf(s, 128, tmp_str, cnt);
-    }    
-    gtk_label_set_text ( GTK_LABEL(sess->progress_label), s );
+    }
+    g_snprintf(s, 128, tmp_str, count, total_count);
+    gtk_label_set_text ( GTK_LABEL(progress_label), s );
   }
+  sess->id_count = 0;
   g_mutex_unlock(sess->mutex);
-  gdk_threads_leave();
+  return FALSE;
 }
 
-static void set_gps_info(const gchar *info, GpsSession *sess)
+static gboolean show_gps_info(GpsSession *sess)
 {
-  gchar s[256];
-  gdk_threads_enter();
   g_mutex_lock(sess->mutex);
   if (sess->ok) {
-    g_snprintf(s, 256, _("GPS Device: %s"), info);
+    gchar s[256];
+    g_snprintf(s, 256, _("GPS Device: %s"), sess->info);
     gtk_label_set_text ( GTK_LABEL(sess->gps_label), s );
   }
+  sess->id_info = 0;
   g_mutex_unlock(sess->mutex);
-  gdk_threads_leave();
+  return FALSE;
 }
 
 /*
@@ -1010,7 +1165,8 @@ static void process_line_for_gps_info ( const gchar *line, GpsSession *sess )
         info[ilen++] = ch;
       }
       info[ilen++] = 0;
-      set_gps_info(info, sess);
+      sess->info = g_strdup (info);
+      sess->id_info = gdk_threads_add_idle ( (GSourceFunc)show_gps_info, sess );
     }
     g_strfreev(tokens);
   }
@@ -1023,50 +1179,70 @@ static void process_line_for_gps_info ( const gchar *line, GpsSession *sess )
       n_tokens++;
 
     if (n_tokens > 1) {
-      set_gps_info(tokens[1], sess);
+      sess->info = g_strdup (tokens[1]);
+      sess->id_info = gdk_threads_add_idle ( (GSourceFunc)show_gps_info, sess );
     }
     g_strfreev(tokens);
   }
+
+  if (strstr(line, "[ERROR] GPS")) {
+    gchar **tokens = g_strsplit(line, "\n", 0);
+    sess->info = g_strdup(tokens[0]);
+    sess->id_info = gdk_threads_add_idle ( (GSourceFunc)show_gps_info, sess );
+    g_strfreev(tokens);
+  }
+
+  if (strstr(line, "an't in")) {
+    gchar **tokens = g_strsplit(line, "\n", 0);
+    sess->info = g_strdup(tokens[0]);
+    sess->id_info = gdk_threads_add_idle ( (GSourceFunc)show_gps_info, sess );
+    g_strfreev(tokens);
+  }
+
+  if (strstr(line, "Can't get waypoint")) {
+    gchar **tokens = g_strsplit(line, "\n", 0);
+    sess->info = g_strdup(tokens[0]);
+    sess->id_info = gdk_threads_add_idle ( (GSourceFunc)show_gps_info, sess );
+    g_strfreev(tokens);
+  }
+}
+
+static gboolean show_gps_status_working ( GpsSession *sess )
+{
+  g_mutex_lock(sess->mutex);
+  if ( sess->ok ) {
+    gtk_label_set_text ( GTK_LABEL(sess->status_label), _("Status: Working...") );
+  }
+  sess->id_status_working = 0;
+  g_mutex_unlock(sess->mutex);
+  return FALSE;
 }
 
 static void gps_download_progress_func(BabelProgressCode c, gpointer data, GpsSession * sess )
 {
   gchar *line;
 
-  gdk_threads_enter ();
-  g_mutex_lock(sess->mutex);
-  if (!sess->ok) {
-    g_mutex_unlock(sess->mutex);
-    gps_session_delete(sess);
-    gdk_threads_leave();
+  if ( !sess->ok ) {
+    //gps_session_delete(sess);
+    sess->thread_complete = TRUE;
+    g_debug ("THREAD EXIT INTERUPPT");
     g_thread_exit ( NULL );
   }
-  g_mutex_unlock(sess->mutex);
-  gdk_threads_leave ();
 
   switch(c) {
   case BABEL_DIAG_OUTPUT:
     line = (gchar *)data;
 
-    gdk_threads_enter();
-    g_mutex_lock(sess->mutex);
-    if (sess->ok) {
-      gtk_label_set_text ( GTK_LABEL(sess->status_label), _("Status: Working...") );
-    }
-    g_mutex_unlock(sess->mutex);
-    gdk_threads_leave();
+    sess->id_status_working = gdk_threads_add_idle ( (GSourceFunc)show_gps_status_working, sess );
 
     /* tells us the type of items that will follow */
     if (strstr(line, "Xfer Wpt")) {
-      sess->progress_label = sess->wp_label;
       sess->progress_type = WPT;
     }
     if (strstr(line, "Xfer Trk")) {
-      sess->progress_label = sess->trk_label;
       sess->progress_type = TRK;
     }
     if (strstr(line, "Xfer Rte")) {
-      sess->progress_label = sess->rte_label;
       sess->progress_type = RTE;
     }
 
@@ -1079,13 +1255,32 @@ static void gps_download_progress_func(BabelProgressCode c, gpointer data, GpsSe
         sscanf(line+17, "%x", &lsb); 
         sscanf(line+20, "%x", &msb);
         cnt = lsb + msb * 256;
-        set_total_count(cnt, sess);
-        sess->count = 0;
+        if ( sess->progress_type == RTE ) {
+          // Maybe a gpsbabel bug/feature (upto at least v1.4.3 or maybe my Garmin device) but the count always seems x2 too many for routepoints
+          gint mycnt = (cnt / 2) + 1;
+          sess->rte_total_count = mycnt;
+          sess->rte_count = 0;
+        }
+        else if ( sess->progress_type == WPT ) {
+          sess->wpt_total_count = cnt;
+          sess->wpt_count = 0;
+        }
+        else {
+          sess->trk_total_count = cnt;
+          sess->trk_count = 0;
+        }
+        sess->id_total_count = gdk_threads_add_idle ( (GSourceFunc)show_total_count, sess);
       }
     }
     if ( strstr(line, "WPTDAT") || strstr(line, "TRKHDR") || strstr(line, "TRKDAT") || strstr(line, "RTEHDR") || strstr(line, "RTEWPT") ) {
-      sess->count++;
-      set_current_count(sess->count, sess);
+      if ( strstr(line, "WPTDAT") )
+        sess->wpt_count++;
+      else if ( strstr(line, "TRKHDR") || strstr(line, "TRKDAT") )
+        sess->trk_count++;
+      else
+        // "RTEHDR" || "RTEWPT"
+        sess->rte_count++;
+      sess->id_count = gdk_threads_add_idle ( (GSourceFunc)show_current_count, sess);
     }
     break;
   case BABEL_DONE:
@@ -1093,7 +1288,6 @@ static void gps_download_progress_func(BabelProgressCode c, gpointer data, GpsSe
   default:
     break;
   }
-
 }
 
 static void gps_upload_progress_func(BabelProgressCode c, gpointer data, GpsSession * sess )
@@ -1101,28 +1295,17 @@ static void gps_upload_progress_func(BabelProgressCode c, gpointer data, GpsSess
   gchar *line;
   static int cnt = 0;
 
-  gdk_threads_enter ();
-  g_mutex_lock(sess->mutex);
-  if (!sess->ok) {
-    g_mutex_unlock(sess->mutex);
-    gps_session_delete(sess);
-    gdk_threads_leave();
+  if ( !sess->ok ) {
+    //gps_session_delete(sess);
+    sess->thread_complete = TRUE;
     g_thread_exit ( NULL );
   }
-  g_mutex_unlock(sess->mutex);
-  gdk_threads_leave ();
 
   switch(c) {
   case BABEL_DIAG_OUTPUT:
     line = (gchar *)data;
 
-    gdk_threads_enter();
-    g_mutex_lock(sess->mutex);
-    if (sess->ok) {
-      gtk_label_set_text ( GTK_LABEL(sess->status_label), _("Status: Working...") );
-    }
-    g_mutex_unlock(sess->mutex);
-    gdk_threads_leave();
+    sess->id_status_working = gdk_threads_add_idle ( (GSourceFunc)show_gps_status_working, sess );
 
     process_line_for_gps_info ( line, sess );
 
@@ -1133,39 +1316,36 @@ static void gps_upload_progress_func(BabelProgressCode c, gpointer data, GpsSess
         sscanf(line+17, "%x", &lsb); 
         sscanf(line+20, "%x", &msb);
         cnt = lsb + msb * 256;
-        /* set_total_count(cnt, sess); */
-        sess->count = 0;
+        //sess->count = 0; ?? wpt, trk and/or rte?? or none
       }
     }
     if ( strstr(line, "WPTDAT")) {
-      if (sess->count == 0) {
-        sess->progress_label = sess->wp_label;
-        sess->progress_type = WPT;
-        set_total_count(cnt, sess);
+      sess->progress_type = WPT;
+      if (sess->wpt_count == 0) {
+        sess->wpt_total_count = cnt;
+        sess->id_total_count = gdk_threads_add_idle ( (GSourceFunc)show_total_count, sess );
       }
-      sess->count++;
-      set_current_count(sess->count, sess);
+      sess->wpt_count++;
+      sess->id_count = gdk_threads_add_idle ( (GSourceFunc)show_current_count, sess );
     }
     if ( strstr(line, "RTEHDR") || strstr(line, "RTEWPT") ) {
-       if (sess->count == 0) {
-         sess->progress_label = sess->rte_label;
-         sess->progress_type = RTE;
-         // Maybe a gpsbabel bug/feature (upto at least v1.4.3 or maybe my Garmin device) but the count always seems x2 too many for routepoints
-         // Anyway since we're uploading - we should know how many points we're going to put!
-         cnt = (cnt / 2) + 1;
-         set_total_count(cnt, sess);
-       }
-       sess->count++;
-       set_current_count(sess->count, sess);
+      sess->progress_type = RTE;
+      if (sess->rte_count == 0) {
+        // Maybe a gpsbabel bug/feature (upto at least v1.4.3 or maybe my Garmin device) but the count always seems x2 too many for routepoints
+        // Anyway since we're uploading - we should know how many points we're going to put!
+        cnt = (cnt / 2) + 1;
+        sess->id_total_count = gdk_threads_add_idle ( (GSourceFunc)show_total_count, sess);
+      }
+      sess->rte_count++;
+      sess->id_count = gdk_threads_add_idle ( (GSourceFunc)show_current_count, sess);
     }
     if ( strstr(line, "TRKHDR") || strstr(line, "TRKDAT") ) {
-      if (sess->count == 0) {
-        sess->progress_label = sess->trk_label;
-       sess->progress_type = TRK;
-        set_total_count(cnt, sess);
+      sess->progress_type = TRK;
+      if (sess->trk_count == 0) {
+        sess->id_total_count = gdk_threads_add_idle ( (GSourceFunc)show_total_count, sess);
       }
-      sess->count++;
-      set_current_count(sess->count, sess);
+      sess->trk_count++;
+      sess->id_count = gdk_threads_add_idle ( (GSourceFunc)show_current_count, sess);
     }
     break;
   case BABEL_DONE:
@@ -1173,32 +1353,45 @@ static void gps_upload_progress_func(BabelProgressCode c, gpointer data, GpsSess
   default:
     break;
   }
+}
 
+static gboolean show_gps_status_end ( GpsSession *sess )
+{
+  g_mutex_lock(sess->mutex);
+  // (Download)Failure could be due to a number of reasons: such as no/wrong device attached or GPSBabel not installed
+  if (!sess->result) {
+    gtk_label_set_text ( GTK_LABEL(sess->status_label), _("Error: No result.") );
+  }
+  else {
+    if (sess->ok) {
+      gtk_label_set_text ( GTK_LABEL(sess->status_label), _("Done.") );
+      gtk_dialog_set_response_sensitive ( GTK_DIALOG(sess->dialog), GTK_RESPONSE_ACCEPT, TRUE );
+      gtk_dialog_set_response_sensitive ( GTK_DIALOG(sess->dialog), GTK_RESPONSE_REJECT, FALSE );
+    }
+  }
+  sess->id_status_end = 0;
+  g_mutex_unlock(sess->mutex);
+  return FALSE;
 }
 
+/**
+ *
+ */
 static void gps_comm_thread(GpsSession *sess)
 {
-  gboolean result;
-
   if (sess->direction == GPS_DOWN) {
     ProcessOptions po = { sess->babelargs, sess->port, NULL, NULL, NULL, NULL };
-    result = a_babel_convert_from (sess->vtl, &po, (BabelStatusFunc) gps_download_progress_func, sess, NULL);
+    sess->result = a_babel_convert_from (sess->vtl, &po, (BabelStatusFunc) gps_download_progress_func, sess, NULL);
   }
   else {
-    result = a_babel_convert_to (sess->vtl, sess->track, sess->babelargs, sess->port,
+    sess->result = a_babel_convert_to (sess->vtl, sess->track, sess->babelargs, sess->port,
         (BabelStatusFunc) gps_upload_progress_func, sess);
   }
 
-  if (!result) {
-    gtk_label_set_text ( GTK_LABEL(sess->status_label), _("Error: couldn't find gpsbabel.") );
-  } 
-  else {
-    g_mutex_lock(sess->mutex);
+  sess->id_status_end = gdk_threads_add_idle ( (GSourceFunc)show_gps_status_end, sess );
+  
+  if (sess->result) {
     if (sess->ok) {
-      gtk_label_set_text ( GTK_LABEL(sess->status_label), _("Done.") );
-      gtk_dialog_set_response_sensitive ( GTK_DIALOG(sess->dialog), GTK_RESPONSE_ACCEPT, TRUE );
-      gtk_dialog_set_response_sensitive ( GTK_DIALOG(sess->dialog), GTK_RESPONSE_REJECT, FALSE );
-
       /* Do not change the view if we are following the current GPS position */
 #if defined (VIK_CONFIG_REALTIME_GPS_TRACKING) && defined (GPSD_API_MAJOR_VERSION)
       if (!sess->realtime_tracking)
@@ -1208,24 +1401,20 @@ static void gps_comm_thread(GpsSession *sess)
           vik_layer_post_read ( VIK_LAYER(sess->vtl), sess->vvp, TRUE );
           /* View the data available */
           vik_trw_layer_auto_set_view ( sess->vtl, sess->vvp ) ;
-          vik_layer_emit_update ( VIK_LAYER(sess->vtl) ); // NB update from background thread
+          vik_layer_emit_update ( VIK_LAYER(sess->vtl) ); // NB update request from background thread
         }
       }
     } else {
-      /* canceled */
+      /* cancelled */
     }
-    g_mutex_unlock(sess->mutex);
   }
 
-  g_mutex_lock(sess->mutex);
   if (sess->ok) {
+    // Thread has completed successfully, but now set to false to avoid 'tell thread to stop' test after dialog run
     sess->ok = FALSE;
-    g_mutex_unlock(sess->mutex);
-  }
-  else {
-    g_mutex_unlock(sess->mutex);
-    gps_session_delete(sess);
   }
+
+  sess->thread_complete = TRUE;
   g_thread_exit(NULL);
 }
 
@@ -1258,7 +1447,7 @@ gint vik_gps_comm ( VikTrwLayer *vtl,
                     gboolean do_waypoints,
                    gboolean turn_off )
 {
-  GpsSession *sess = g_malloc(sizeof(GpsSession));
+  GpsSession *sess = g_malloc0(sizeof(GpsSession));
   char *tracks = NULL;
   char *routes = NULL;
   char *waypoints = NULL;
@@ -1269,7 +1458,6 @@ gint vik_gps_comm ( VikTrwLayer *vtl,
   sess->track = track;
   sess->port = g_strdup(port);
   sess->ok = TRUE;
-  sess->window_title = (dir == GPS_DOWN) ? _("GPS Download") : _("GPS Upload");
   sess->vvp = vvp;
 
   // This must be done inside the main thread as the uniquify causes screen updates
@@ -1305,34 +1493,32 @@ gint vik_gps_comm ( VikTrwLayer *vtl,
   tracks = NULL;
   waypoints = NULL;
 
+  GtkWidget *dialog = NULL;
+
   // Only create dialog if we're going to do some transferring
   if ( do_tracks || do_waypoints || do_routes ) {
-    sess->dialog = gtk_dialog_new_with_buttons ( "", VIK_GTK_WINDOW_FROM_LAYER(vtl), 0, GTK_STOCK_OK, GTK_RESPONSE_ACCEPT, GTK_STOCK_CANCEL, GTK_RESPONSE_REJECT, NULL );
+    dialog = gtk_dialog_new_with_buttons ( "", VIK_GTK_WINDOW_FROM_LAYER(vtl), 0, GTK_STOCK_OK, GTK_RESPONSE_ACCEPT, GTK_STOCK_CANCEL, GTK_RESPONSE_REJECT, NULL );
+    sess->dialog = dialog;
     gtk_dialog_set_response_sensitive ( GTK_DIALOG(sess->dialog),
                                         GTK_RESPONSE_ACCEPT, FALSE );
-    gtk_window_set_title ( GTK_WINDOW(sess->dialog), sess->window_title );
+    gtk_window_set_title ( GTK_WINDOW(sess->dialog), (dir == GPS_DOWN) ? _("GPS Download") : _("GPS Upload") );
 
     sess->status_label = gtk_label_new (_("Status: detecting gpsbabel"));
     gtk_box_pack_start ( GTK_BOX(gtk_dialog_get_content_area(GTK_DIALOG(sess->dialog))), sess->status_label, FALSE, FALSE, 5 );
-    gtk_widget_show_all(sess->status_label);
 
     sess->gps_label = gtk_label_new (_("GPS device: N/A"));
-    sess->ver_label = gtk_label_new ("");
-    sess->id_label = gtk_label_new ("");
-    sess->wp_label = gtk_label_new ("");
+    sess->wpt_label = gtk_label_new ("");
     sess->trk_label = gtk_label_new ("");
     sess->rte_label = gtk_label_new ("");
 
     gtk_box_pack_start ( GTK_BOX(gtk_dialog_get_content_area(GTK_DIALOG(sess->dialog))), sess->gps_label, FALSE, FALSE, 5 );
-    gtk_box_pack_start ( GTK_BOX(gtk_dialog_get_content_area(GTK_DIALOG(sess->dialog))), sess->wp_label, FALSE, FALSE, 5 );
+    gtk_box_pack_start ( GTK_BOX(gtk_dialog_get_content_area(GTK_DIALOG(sess->dialog))), sess->wpt_label, FALSE, FALSE, 5 );
     gtk_box_pack_start ( GTK_BOX(gtk_dialog_get_content_area(GTK_DIALOG(sess->dialog))), sess->trk_label, FALSE, FALSE, 5 );
     gtk_box_pack_start ( GTK_BOX(gtk_dialog_get_content_area(GTK_DIALOG(sess->dialog))), sess->rte_label, FALSE, FALSE, 5 );
 
     gtk_widget_show_all(sess->dialog);
 
-    sess->progress_label = sess->wp_label;
-    sess->total_count = -1;
-
+    gtk_dialog_set_default_response ( GTK_DIALOG(sess->dialog), GTK_RESPONSE_ACCEPT );
     // Starting gps read/write thread
 #if GLIB_CHECK_VERSION (2, 32, 0)
     g_thread_try_new ( "gps_comm_thread", (GThreadFunc)gps_comm_thread, sess, NULL );
@@ -1340,21 +1526,15 @@ gint vik_gps_comm ( VikTrwLayer *vtl,
     g_thread_create ( (GThreadFunc)gps_comm_thread, sess, FALSE, NULL );
 #endif
 
-    gtk_dialog_set_default_response ( GTK_DIALOG(sess->dialog), GTK_RESPONSE_ACCEPT );
-    gtk_dialog_run(GTK_DIALOG(sess->dialog));
-
-    gtk_widget_destroy(sess->dialog);
+    gtk_dialog_run(GTK_DIALOG(dialog));
   }
   else {
     if ( !turn_off )
       a_dialog_info_msg ( VIK_GTK_WINDOW_FROM_LAYER(vtl), _("No GPS items selected for transfer.") );
   }
 
-  g_mutex_lock(sess->mutex);
-
   if (sess->ok) {
     sess->ok = FALSE;   /* tell thread to stop */
-    g_mutex_unlock(sess->mutex);
   }
   else {
     if ( turn_off ) {
@@ -1366,10 +1546,15 @@ gint vik_gps_comm ( VikTrwLayer *vtl,
         a_dialog_error_msg ( VIK_GTK_WINDOW_FROM_LAYER(vtl), _("Could not turn off device.") );
       g_free ( device_off );
     }
-    g_mutex_unlock(sess->mutex);
-    gps_session_delete(sess);
   }
 
+  if ( dialog ) {
+    while ( !sess->thread_complete ) {
+      g_usleep (G_USEC_PER_SEC/10);
+    }
+    gtk_widget_destroy(dialog);
+  }
+  gps_session_delete(sess);
   return 0;
 }
 
@@ -1433,6 +1618,7 @@ static void gps_empty_realtime_cb( gpointer layer_and_vlp[2] )
     return;
   vik_trw_layer_delete_all_waypoints ( vgl-> trw_children[TRW_REALTIME]);
   vik_trw_layer_delete_all_tracks ( vgl-> trw_children[TRW_REALTIME]);
+  vik_trw_layer_delete_all_routes ( vgl-> trw_children[TRW_REALTIME]);
 }
 #endif
 
@@ -1453,6 +1639,7 @@ static void gps_empty_all_cb( gpointer layer_and_vlp[2] )
 #if defined (VIK_CONFIG_REALTIME_GPS_TRACKING) && defined (GPSD_API_MAJOR_VERSION)
   vik_trw_layer_delete_all_waypoints ( vgl-> trw_children[TRW_REALTIME]);
   vik_trw_layer_delete_all_tracks ( vgl-> trw_children[TRW_REALTIME]);
+  vik_trw_layer_delete_all_routes ( vgl-> trw_children[TRW_REALTIME]);
 #endif
 }
 
@@ -1695,6 +1882,13 @@ static gboolean gpsd_data_available(GIOChannel *source, GIOCondition condition,
   return FALSE; /* no further calling */
 }
 
+/**
+ * make_track_name:
+ *
+ * returns allocated string for a new realtime track name
+ * NB no i18n ATM
+ * free string after use
+ */
 static gchar *make_track_name(VikTrwLayer *vtl)
 {
   const gchar basename[] = "REALTIME";
@@ -1708,7 +1902,6 @@ static gchar *make_track_name(VikTrwLayer *vtl)
     i++;
   }
   return(name);
-
 }
 
 static gboolean rt_gpsd_try_connect(gpointer *data)
@@ -1724,12 +1917,13 @@ static gboolean rt_gpsd_try_connect(gpointer *data)
   if (gps_open_r(vgl->gpsd_host, vgl->gpsd_port, /*(struct gps_data_t *)*/vgl->vgpsd) != 0) {
 #elif GPSD_API_MAJOR_VERSION == 5 || GPSD_API_MAJOR_VERSION == 6
   vgl->vgpsd = g_malloc(sizeof(VglGpsd));
-  if (gps_open(vgl->gpsd_host, vgl->gpsd_port, &vgl->vgpsd->gpsd) != 0) {
+  vgl->vgpsd->gpsd_open = gps_open ( vgl->gpsd_host, vgl->gpsd_port, &vgl->vgpsd->gpsd );
+  if ( vgl->vgpsd->gpsd_open != 0 ) {
 #else
 // Delibrately break compilation...
 #endif
-    g_warning("Failed to connect to gpsd at %s (port %s). Will retry in %d seconds",
-                     vgl->gpsd_host, vgl->gpsd_port, vgl->gpsd_retry_interval);
+    g_debug("Failed to connect to gpsd at %s (port %s). Will retry in %d seconds",
+            vgl->gpsd_host, vgl->gpsd_port, vgl->gpsd_retry_interval);
     return TRUE;   /* keep timer running */
   }
 
@@ -1747,9 +1941,13 @@ static gboolean rt_gpsd_try_connect(gpointer *data)
     VikTrwLayer *vtl = vgl->trw_children[TRW_REALTIME];
     vgl->realtime_track = vik_track_new();
     vgl->realtime_track->visible = TRUE;
-    vik_trw_layer_add_track(vtl, make_track_name(vtl), vgl->realtime_track);
+    gchar *name = make_track_name(vtl);
+    vik_trw_layer_add_track(vtl, name, vgl->realtime_track);
+    g_free(name);
   }
 
+  vgl->connected_to_gpsd = TRUE;
+
 #if GPSD_API_MAJOR_VERSION == 3 || GPSD_API_MAJOR_VERSION == 4
   gps_set_raw_hook(&vgl->vgpsd->gpsd, gpsd_raw_hook);
 #endif
@@ -1771,18 +1969,12 @@ static gboolean rt_gpsd_try_connect(gpointer *data)
 
 static gboolean rt_ask_retry(VikGpsLayer *vgl)
 {
-  GtkWidget *dialog = gtk_message_dialog_new (VIK_GTK_WINDOW_FROM_LAYER(vgl),
-                          GTK_DIALOG_DESTROY_WITH_PARENT,
-                          GTK_MESSAGE_QUESTION,
-                          GTK_BUTTONS_YES_NO,
-                          "Failed to connect to gpsd at %s (port %s)\n"
-                          "Should Viking keep trying (every %d seconds)?",
-                          vgl->gpsd_host, vgl->gpsd_port,
-                          vgl->gpsd_retry_interval);
-
-  gint res = gtk_dialog_run(GTK_DIALOG(dialog));
-  gtk_widget_destroy(dialog);
-  return (res == GTK_RESPONSE_YES);
+  gchar *msg = g_strdup_printf ( _("Failed to connect to gpsd at %s (port %s)\n"
+                                   "Should Viking keep trying (every %d seconds)?"),
+                                   vgl->gpsd_host, vgl->gpsd_port, vgl->gpsd_retry_interval );
+  gboolean ans = a_dialog_yes_or_no ( VIK_GTK_WINDOW_FROM_LAYER(vgl), msg, NULL );
+  g_free ( msg );
+  return ans;
 }
 
 static gboolean rt_gpsd_connect(VikGpsLayer *vgl, gboolean ask_if_failed)
@@ -1790,7 +1982,7 @@ static gboolean rt_gpsd_connect(VikGpsLayer *vgl, gboolean ask_if_failed)
   vgl->realtime_retry_timer = 0;
   if (rt_gpsd_try_connect((gpointer *)vgl)) {
     if (vgl->gpsd_retry_interval <= 0) {
-      g_warning("Failed to connect to gpsd but will not retry because retry intervel was set to %d (which is 0 or negative)", vgl->gpsd_retry_interval);
+      g_warning("Failed to connect to gpsd but will not retry because retry interval was set to %d (which is 0 or negative)", vgl->gpsd_retry_interval);
       return FALSE;
     }
     else if (ask_if_failed && !rt_ask_retry(vgl))
@@ -1821,7 +2013,8 @@ static void rt_gpsd_disconnect(VikGpsLayer *vgl)
 #if GPSD_API_MAJOR_VERSION == 4 || GPSD_API_MAJOR_VERSION == 5 || GPSD_API_MAJOR_VERSION == 6
     gps_stream(&vgl->vgpsd->gpsd, WATCH_DISABLE, NULL);
 #endif
-    gps_close(&vgl->vgpsd->gpsd);
+    if ( vgl->vgpsd->gpsd_open == 0 )
+      (void)gps_close(&vgl->vgpsd->gpsd);
 #if GPSD_API_MAJOR_VERSION == 3
     free(vgl->vgpsd);
 #elif GPSD_API_MAJOR_VERSION == 4 || GPSD_API_MAJOR_VERSION == 5 || GPSD_API_MAJOR_VERSION == 6
@@ -1835,6 +2028,7 @@ static void rt_gpsd_disconnect(VikGpsLayer *vgl)
       vik_trw_layer_delete_track(vgl->trw_children[TRW_REALTIME], vgl->realtime_track);
     vgl->realtime_track = NULL;
   }
+  vgl->connected_to_gpsd = FALSE;
 }
 
 static void gps_start_stop_tracking_cb( gpointer layer_and_vlp[2])